Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I2C hot switch master <-> slave #182

Closed
wants to merge 5 commits into from
Closed

I2C hot switch master <-> slave #182

wants to merge 5 commits into from
+164 −77

Conversation

maidnl
Copy link
Contributor

@maidnl maidnl commented Nov 10, 2023

Solve: #180
This PR introduces the possibility to change back and forth the role on the I2C from Master to Slave and vice versa.

@maidnl maidnl requested review from aentinger and facchinm November 10, 2023 13:26
@maidnl maidnl mentioned this pull request Nov 10, 2023
Closed
@per1234 per1234 linked an issue Nov 10, 2023 that may be closed by this pull request
UNO R4 access to DS1307 only works if board is used as a master exclusively #180
Closed
@per1234 per1234 added the topic: code Related to content of the project itself label Nov 10, 2023
aentinger
aentinger requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I believe err can be dropped. Let's do that and than this PR can be merged 👍

libraries/Wire/Wire.cpp Show resolved Hide resolved
@facchinm
Copy link
Member

Before merging I'd try a cleanup to get the minimum amount of changes in IRQManager (I know it might be hard but it could avoid cross references difficult to spot and fix afterwards)

@facchinm facchinm marked this pull request as draft November 13, 2023 10:31
@maidnl maidnl mentioned this pull request Nov 15, 2023
Merged
@maidnl maidnl closed this Nov 15, 2023
@maidnl maidnl reopened this Nov 15, 2023
@maidnl
Copy link
Contributor Author

maidnl commented Nov 15, 2023

This PR is not longer needed because this new PR #191 supersedes this one

@maidnl maidnl closed this Nov 15, 2023
@per1234 per1234 added type: imperfection Perceived defect in any part of project conclusion: duplicate Has already been submitted labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aentinger aentinger aentinger requested changes

@facchinm facchinm Awaiting requested review from facchinm

Assignees
No one assigned
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UNO R4 access to DS1307 only works if board is used as a master exclusively
4 participants
@maidnl @facchinm @aentinger @per1234